Add lib declaration for RegExp#unicodeSets #57111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
approved these changes
Feb 15, 2024
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
This PR is good as-is, but now that it's reviewed, feel free to fix any duped words or typos you want. It's the perfect place to do so.
This should wait until 5.4 beta is over since it's not a bug fix.
Contributor
Author
|
I think this is good to go |
Member
|
Some tests failed last time CI ran. Does this need to have main merged into it? Or is it the code itself that is failing? |
Josh-Cena
force-pushed
the
unicodeSets
branch
from
51f2e68 to
cc8f399
Compare
Contributor
Author
|
Mmm, apparently there are other config files that need to be changed but I'm unaware of. |
Contributor
Author
|
Wow, the number of baselines updated by an extra lib is surprising. |
Contributor
Author
|
@sandersn Now that 5.4 is out, will this be merged soon? (I will resolve the conflicts when I get to a computer) |
Member
|
Thanks for the reminder. I'll double-check it and merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57055