Track symbols per type thats cached and dont keep adding to them #56421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
Member
|
Here's a test that exhibits the problem: https://github.com/jakebailey/TypeScript/blob/fix-51721/tests/cases/compiler/trackedSymbolsNoCrash.ts |
jakebailey
approved these changes
Nov 16, 2023
Member
Author
|
@typescript-bot cherry-pick this to release-5.3 |
Collaborator
|
Heya @sheetalkamat, I've started to run the task to cherry-pick this into |
Member
|
Cherry-picking is currently broken; I'm trying to quick resurrect my change that ports it to GHA to try and solve it "once and for all" since I haven't been able to figure out what broke there... |
Collaborator
|
Hey @sheetalkamat, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-5.3 manually. |
DanielRosenwasser
pushed a commit
that referenced
this pull request
Nov 16, 2023
) Co-authored-by: Jake Bailey <[email protected]>
DanielRosenwasser
pushed a commit
that referenced
this pull request
Nov 16, 2023
) Co-authored-by: Jake Bailey <[email protected]>
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56371
TODO: test