Revert collecting only outermost intra expression inference sites #54613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Andarist
changed the title
jakebailey
approved these changes
Jun 12, 2023
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Thanks for keeping the revert commit explicit. Given this is just a plain revert of a PR from last week (not in any release), I'll just approve and merge to back it out.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #54186 and adds new test cases.
While working on related stuff, I noticed that this improvement of mine was terrible and that it regressed some cases that were working before. The perf improvement was still there, just for a subset of possible cases. I now explored how this whole intra expression inference works and have much better understanding of the overall algorithm. I have some ideas how to deduplicate some work here but I will do that in a follow up PR. For the time being, it's much more important to land this revert that fixes some regressions.
cc @weswigham @jakebailey