fix(39022): If exported variable is renamed, tsc will generate code with a syntax error #41156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Milestone Bug
rbuckton
suggested changes
Feb 2, 2021
Contributor
rbuckton
left a comment
rbuckton
left a comment
There was a problem hiding this comment.
It would be better to always parenthesize. I am also considering whether it would be feasible to introduce our auto-parenthesization from the node factory into the substitution performed by the printer.
rbuckton
approved these changes
Feb 4, 2021
Contributor
rbuckton
left a comment
rbuckton
left a comment
There was a problem hiding this comment.
The places where parens are unnnecessary is unavoidable at the moment. I'm investigating a change to the emitter that handles substitution as part of a transformation before printing which would remove the need for this fix, but unfortunately the change I'm investigating is not likely to be ready for 4.2.
Thanks for the effort on this!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39022