ADL-proof implementation of erase_if and related algorithms
#4217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/std/tests/VSO_0000000_instantiate_containers/test.compile.pass.cpp
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Nov 29, 2023
Member
|
Thanks! I pre-emptively pushed a |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for improving my favorite algorithms! 🎉 🥇 😻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #140 and #1596. Note that there'll be a merge conflict with #4216.
_STD-qualification for internal functions should become complete for following headers:experimental/dequeexperimental/forward_listexperimental/listexperimental/mapexperimental/setexperimental/stringexperimental/unordered_mapexperimental/unordered_setexperimental/vectorUnfortunately, I failed to find how to test ADL-proofness for
std::(experimental::)erase. Not sure whether this is possible.Edit:
Overloads forOverloads forflat_meowalso need to fixed, but perhaps this should be done after themainbranch is updated.flat_(multi)setare already fixed in #4050.