fix: use latest value instead of raw value in ramp #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@nulinspiratie thanks. Is it ok that I write some tests for this and push to your branch? |
Collaborator
|
@nulinspiratie I added some tests for this. @QCoDeS/core would be great if anyone wants to review the tests |
giulioungaretti
pushed a commit
that referenced
this pull request
Nov 7, 2017
Author: Serwan Asaad <[email protected]> fix: use latest value instead of raw value in ramp (#851)
Contributor
Author
|
@jenshnielsen I wasn't available the past days, thanks for adding tests to it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
After switching the order of scaling and ramping (#788), the starting value should no longer be the raw value, but the scaled value.
@jenshnielsen @WilliamHPNielsen