Fix potential deadlock when creating a ServiceClient instance

[0xced]

By adding missing ConfigureAwait(false) calls

[MattB-msft]

@0xced We cannot accept the merge but will pick this up and add this to our main repro. We will close the pr when we push this fix.
thanks !

[0xced]

Have you considered turning this GitHub repository into your main repository? Pretty much all teams at Microsoft are now operating on GitHub and accepting pull request the GitHub way.

[MattB-msft]

Fair question :)
Unfortunately this is not possible at this time as this client depends on non public assets from our underlying server infrastructure to build that are undergoing significant redesign and changes.

It is out goal to get there at some point as the dependencies reach the point where we can post them, using this repro for our primary source and build test publish on our internal ado systems. We are still a ways off on it. This challenge is primarily responsible for the delay in getting to a 1.0 for us.

Again, it is our goal to get there. We have taken the git as primary source with several of our newer tools that rely on this lib and will continue to do that going forward.