Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Conversation

@SergeyTeplyakov
Copy link
Contributor

Have no idea why Roslyn-based changes where applied with this pull request as well. Reverting it back.

Reverts #68

SergeyTeplyakov added a commit that referenced this pull request Jun 24, 2015
Revert "Add Contributing.md with a set of label descriptions."
@SergeyTeplyakov SergeyTeplyakov merged commit dc07514 into master Jun 24, 2015
@sharwell
Copy link
Contributor

@SergeyTeplyakov

  1. This occurred for the same reason Add some missing system contracts; fix bad contracts in Application and ... #21 had issues. Pull request Add Contributing.md with a set of label descriptions. #68 was sent from your master branch, so when you later updated your master branch the new commits were automatically appended to the pull request. I included additional information about this scenario in Pull requests policies #62.
  2. I think it would make sense to force-push to the master branch here to revert Add Contributing.md with a set of label descriptions. #68 by completely removing the commit from history. This is something we want to avoid in the future, but little (if any) work has been created on top of the current master branch and the repository currently contains new binary files which will never be used.

@SergeyTeplyakov
Copy link
Contributor Author

Yep, I know why this happens. I'm using different local branches for different features right now.

I thought about force-push, but decided that this could do more harm than benefits...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants