Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Conversation

@sharwell
Copy link
Contributor

@sharwell sharwell commented Jul 9, 2015

This pull request resolves the conflicts to merge #84.

SergeyTeplyakov added a commit that referenced this pull request Jul 9, 2015
@SergeyTeplyakov SergeyTeplyakov merged commit 89035ab into microsoft:master Jul 9, 2015
@sharwell sharwell deleted the merge-84 branch July 9, 2015 22:28
@SergeyTeplyakov
Copy link
Contributor

👍

@thomas-delahaye
Copy link

Unfortunately, the contracts for IDictionary<TKey, TValue>.ContainsKey and the like might not be correct for all implementations. The MSDN site for IDictionary<TKey, TValue> says in the remarks "Implementations can vary in whether they allow key to be null."...
The same applies to Add(TKey, TValue) and Item[TKey] (but no remarks for Remove(TKey) and TryGetValue(TKey, out TValue)...).

@sharwell
Copy link
Contributor Author

@thomas-delahaye Can you create a separate issue for that? This PR is merged and treated as effectively "closed", but I don't think we should lose track of your findings. (and I'm really sorry about the delay in responding!)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants