[Beta] Utilize the OpenTelemetry Resource Detectors #1245
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacksonWeber
commented
Nov 16, 2023
| import { Attributes } from "@opentelemetry/api"; | ||
| import { SemanticResourceAttributes } from "@opentelemetry/semantic-conventions"; | ||
| import { detectResourcesSync } from '@opentelemetry/resources'; | ||
| import { azureFunctionsDetector } from '@opentelemetry/resource-detector-azure/build/src/detectors/AzureFunctionsDetector'; |
Contributor
Author
There was a problem hiding this comment.
Excuse the strange import path here. Functions detector isn't exported from the index in the resource detector. Addressed here: open-telemetry/opentelemetry-js-contrib#1800
Member
|
Let's sync to discuss this, I though we were adding all the detectors in distro, there are pros/cons for each approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use the OTel Azure resource detectors in the agent loader files.