Metric Aggregation metadata is stored into a field instead of properties dictionary#929
Merged
cijothomas merged 5 commits intodevelopfrom Oct 3, 2018
Merged
Conversation
…ties in Properties Getter method. This should improve performance as MetricExtractor sits before sampling, and accessing Properties ConcurrentDictionary is avoided until later in the pipeline. With sampling most items are dropped and hence this gives perf boost.
Dmitry-Matveev
approved these changes
Oct 2, 2018
| { | ||
| extractionPipelineInfo = extractionPipelineInfo + "; "; | ||
| } | ||
| extractionPipelineInfo = String.Empty; |
Contributor
There was a problem hiding this comment.
is stylecop fine with String uppercased? I'm surprised
SergeyKanzhelev
approved these changes
Oct 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metric Aggregation metadata is stored into a field instead of properties dictionary, to improve performance.
When someone read the properties, the field value is copied to the properties, so change in behavior.
Since metric aggregator sits before Sampling, this avoids the Properties (ConcurrentDictionary) access until late in the pipeline (serialization). In effect, for items that are dropped after sampling, no Properties access.
Fix #930
For significant contributions please make sure you have completed the following items: