Skip to content

Bumping CurrentInvariantVersion for QuickPulse. #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tokaplan merged 6 commits into from
Dec 9, 2020
Merged

Bumping CurrentInvariantVersion for QuickPulse. #2123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dfbc36f
Endpoint and ping interval hints for QuickPulseModule.
tokaplan Dec 1, 2020
aadd013
Updating changelog.md with the PR link for the change.
tokaplan Dec 1, 2020
5d9dd87
StyleCop error fix.
tokaplan Dec 1, 2020
cf07b44
Bumping CurrentInvariantVersion for QuickPulse.
tokaplan Dec 4, 2020
1b357b6
Merge branch 'develop' into develop
tokaplan Dec 4, 2020
0f78ab7
Unit test fixes.
tokaplan Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions WEB/Src/PerformanceCollector/Perf.Tests/QuickPulse/QuickPulseServiceClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1458,8 +1458,8 @@ public void QuickPulseServiceClientSubmitsInvariantVersionToServiceWithPing()

// ASSERT
Assert.AreEqual(1, this.pings.Count);
Assert.AreEqual(4, this.pings[0].Item1.InvariantVersion);
Assert.AreEqual(4, this.pings[0].Item3.InvariantVersion);
Assert.AreEqual(5, this.pings[0].Item1.InvariantVersion);
Assert.AreEqual(5, this.pings[0].Item3.InvariantVersion);
}

[TestMethod]
Expand Down Expand Up @@ -1493,7 +1493,7 @@ public void QuickPulseServiceClientSubmitsInvariantVersionToServiceWithSubmitSam

// ASSERT
Assert.AreEqual(1, this.samples.Count);
Assert.AreEqual(4, this.samples[0].Item3.InvariantVersion);
Assert.AreEqual(5, this.samples[0].Item3.InvariantVersion);
}

[TestMethod]
Expand Down
3 changes: 2 additions & 1 deletion ...or/PerformanceCollector/Implementation/QuickPulse/Service contract/MonitoringDataPoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,12 @@
internal struct MonitoringDataPoint
{
/*
* 5 - adding support for ping interval hint and endpoint redirect hint
* 4 - adding errors for extended backchannel, adding EventTelemetryDocument and TraceTelemetryDocument, adding DocumentStreamId for full documents,
* adding ProcessorCount
* 3 - adding TopCpuProcesses
*/
public const int CurrentInvariantVersion = 4;
public const int CurrentInvariantVersion = 5;

[DataMember]
public string Version { get; set; }
Expand Down