This repository was archived by the owner on Jul 5, 2020. It is now read-only.
Fix 503 WCF test that sometimes fails because of intermediate request#908
Merged
Fix 503 WCF test that sometimes fails because of intermediate request#908
Conversation
| if (this.childRequestTrackingSuppressionModule?.OnEndRequest_ShouldLog(context) ?? true) | ||
| { | ||
| var intermediateRequest = (RequestTelemetry)context.Items[IntermediateRequestHttpContextKey]; | ||
| if (intermediateRequest != null) |
Member
There was a problem hiding this comment.
Is there a guarantee that internal request will reach this OnEndRequest handler faster all the time?
I remember that with TransferRequestHandler we didn't have such a guarantee as per @MS-TimothyMothra.
Without that, the tests may still fail very rarely but customers with high load of requests would sometimes see both reported vs. one reported.
Author
There was a problem hiding this comment.
yes, it is guaranteed by TelemteryCorrelation package - it first fires event that there was 'intermediate activity' and right after that would report that request was ended.
This change only reduces noise in the reporting and tests only helped to notice this noise
TimothyMothra
approved these changes
May 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging #898 I found that some Web Func testsfail sometimes in external, hosted build.
It happens with WCF app tests because intermediate request is sometimes tracked for non-reported handlers.
To fix it, I started tracking intermediate request together with 'main' request. I.e. intermediate requests would never be reported for non-tracked handlers. After ~15 hosted test runs, all web func tests pass.
It should also reduce the noise for users.