This repository was archived by the owner on Jul 5, 2020. It is now read-only.
Support Cross-Platform CPU and Memory counters.#1195
Merged
cijothomas merged 41 commits intodevelopfrom Jun 13, 2019
Merged
Conversation
…to avoid interference with other tests
.../Perf.Shared.NetStandard20Net45/StandardPerformanceCollector/StandardPerformanceCollector.cs
Show resolved
Hide resolved
Src/PerformanceCollector/Perf.Shared/Implementation/PerformanceCounterUtility.cs
Show resolved
Hide resolved
|
I see a lot of methods with platform preprocessors (NET45, NETSTANDARD, etc). what do you think? |
… and was hardcoded to be true when sending telemetry.
5 tasks
cijothomas
changed the title
Dmitry-Matveev
approved these changes
Jun 11, 2019
Member
Dmitry-Matveev
left a comment
Dmitry-Matveev
left a comment
There was a problem hiding this comment.
Approved with comments to address.
Src/PerformanceCollector/Perf.Shared.NetStandard20/PerformanceCollectorXPlatform.cs
Outdated
Show resolved
Hide resolved
Src/PerformanceCollector/Perf.Shared.NetStandard20/XPlatProcessCPUPerformanceCounter.cs
Show resolved
Hide resolved
Src/PerformanceCollector/Perf.Shared.NetStandard20/XPlatProcessMemoryPerformanceCounter.cs
Outdated
Show resolved
Hide resolved
Src/PerformanceCollector/Perf.Shared.NetStandard20/XPlatProcessCPUPerformanceCounter.cs
Outdated
Show resolved
Hide resolved
Src/PerformanceCollector/Perf.Shared.NetStandard20/XPlatProcessMemoryPerformanceCounter.cs
Outdated
Show resolved
Hide resolved
Src/PerformanceCollector/Perf.Shared.NetStandard20/XPlatProcessMemoryPerformanceCounter.cs
Show resolved
Hide resolved
Src/PerformanceCollector/Perf.Shared/Implementation/PerformanceCollectorEventSource.cs
Outdated
Show resolved
Hide resolved
Src/PerformanceCollector/Perf.Shared/Implementation/PerformanceCounterUtility.cs
Show resolved
Hide resolved
...erformanceCollector/Perf.Shared.NetStandard20/XPlatProcessCPUPerformanceCounterNormalized.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1189
@SergeyKanzhelev @Dmitry-Matveev @lmolkova @MS-TimothyMothra Please share your thoughts.
Some highlights:
Will eventually enable Linux CI builds for this repo to get automatic tests.