This repository was archived by the owner on Oct 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
NLog ApplicationInsightsTarget Flush with async delay #176
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
aee203a
NLog ApplicationInsightsTarget Flush with async delay when something …
snakefoot 7f60898
NLog ApplicationInsightsTarget Flush with async delay when something …
snakefoot 20354cc
Merge branch 'develop' into develop
snakefoot e74909e
NLog ApplicationInsightsTarget Flush with async delay when something …
snakefoot effb3df
Merge branch 'develop' of https://github.com/snakefoot/ApplicationIns…
snakefoot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,6 +28,7 @@ namespace Microsoft.ApplicationInsights.NLogTarget | |
| public sealed class ApplicationInsightsTarget : TargetWithLayout | ||
| { | ||
| private TelemetryClient telemetryClient; | ||
| private DateTime lastLogEventTime; | ||
|
|
||
| /// <summary> | ||
| /// Initializers a new instance of ApplicationInsightsTarget type. | ||
|
|
@@ -108,6 +109,8 @@ protected override void Write(LogEventInfo logEvent) | |
| throw new ArgumentNullException("logEvent"); | ||
| } | ||
|
|
||
| this.lastLogEventTime = DateTime.UtcNow; | ||
|
|
||
| if (logEvent.Exception != null) | ||
| { | ||
| this.SendException(logEvent); | ||
|
|
@@ -127,7 +130,17 @@ protected override void FlushAsync(AsyncContinuation asyncContinuation) | |
| try | ||
| { | ||
| this.TelemetryClient.Flush(); | ||
| asyncContinuation(null); | ||
| if (DateTime.UtcNow.AddSeconds(-30) > this.lastLogEventTime) | ||
| { | ||
| // Nothing has been written, so nothing to wait for | ||
| asyncContinuation(null); | ||
| } | ||
| else | ||
| { | ||
| // Documentation says it is important to wait after flush, else nothing will happen | ||
| // https://docs.microsoft.com/en-us/azure/application-insights/app-insights-api-custom-events-metrics#flushing-data | ||
| System.Threading.Tasks.Task.Delay(500).ContinueWith((task) => asyncContinuation(null)); | ||
|
||
| } | ||
| } | ||
| catch (Exception ex) | ||
| { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove
en-USfrom link so it will direct to localized version of the docThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed