This repository was archived by the owner on Jun 10, 2020. It is now read-only.
Make W3C Correlation default and leverage native W3C support from new System.Diagnostics.DiagnosticSource Activity#958
Merged
cijothomas merged 34 commits intodevelopfrom Aug 27, 2019
Merged
Conversation
lmolkova
suggested changes
Aug 23, 2019
...plicationInsights.AspNetCore/DiagnosticListeners/Implementation/HostingDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
...plicationInsights.AspNetCore/DiagnosticListeners/Implementation/HostingDiagnosticListener.cs
Show resolved
Hide resolved
...plicationInsights.AspNetCore/DiagnosticListeners/Implementation/HostingDiagnosticListener.cs
Show resolved
Hide resolved
...plicationInsights.AspNetCore/DiagnosticListeners/Implementation/HostingDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
...plicationInsights.AspNetCore/DiagnosticListeners/Implementation/HostingDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
...plicationInsights.AspNetCore/DiagnosticListeners/Implementation/HostingDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
...plicationInsights.AspNetCore/DiagnosticListeners/Implementation/HostingDiagnosticListener.cs
Show resolved
Hide resolved
...plicationInsights.AspNetCore/DiagnosticListeners/Implementation/HostingDiagnosticListener.cs
Show resolved
Hide resolved
...plicationInsights.AspNetCore/DiagnosticListeners/Implementation/HostingDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
...plicationInsights.AspNetCore/DiagnosticListeners/Implementation/HostingDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
anarsen
reviewed
Aug 26, 2019
test/Microsoft.ApplicationInsights.AspNetCore.Tests/Helpers/CommonMocks.cs
Show resolved
Hide resolved
This reverts commit 2f1427a.
lmolkova
reviewed
Aug 27, 2019
...icrosoft.ApplicationInsights.AspNetCore/Implementation/TelemetryConfigurationOptionsSetup.cs
Show resolved
Hide resolved
lmolkova
reviewed
Aug 27, 2019
...plicationInsights.AspNetCore/DiagnosticListeners/Implementation/HostingDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
Aug 27, 2019
lmolkova
left a comment
lmolkova
left a comment
There was a problem hiding this comment.
left a couple of comments, the only major one is correlation-context on 2.x case with W3C headers.
cijothomas
changed the title
…n 7.2 which is required for new Activity span types.
lmolkova
reviewed
Aug 27, 2019
| private static void ReadCorrelationContext(IHeaderDictionary requestHeaders, Activity activity) | ||
| { | ||
| string[] baggage = requestHeaders.GetCommaSeparatedValues(RequestResponseHeaders.CorrelationContextHeader); | ||
| if (baggage != StringValues.Empty && !activity.Baggage.Any()) |
There was a problem hiding this comment.
if you want to avoid adding baggage to Activity that already had some baggage (why?) check for baggage presence before you read headers and return.
Contributor
Author
There was a problem hiding this comment.
Got it.. will address it next PR (for 3.0 support)
lmolkova
reviewed
Aug 27, 2019
| 20, | ||
| Message = "Message: '{0}'.", | ||
| Level = EventLevel.Verbose)] | ||
| public void HostingListenerVerboe(string message, string appDomainName = "Incorrect") |
There was a problem hiding this comment.
Suggested change
| public void HostingListenerVerboe(string message, string appDomainName = "Incorrect") | |
| public void HostingListenerVerbose(string message, string appDomainName = "Incorrect") |
Also, do we really need both: Informational and verbose?
Contributor
Author
There was a problem hiding this comment.
Will address it next PR (for 3.0 support)
lmolkova
approved these changes
Aug 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AspNetCore RequestCollection specific changes, followup for the base SDK changes introduced in the PR:
microsoft/ApplicationInsights-dotnet#1193
Also Fixes:
#956
#900
To do:
3.XX support (separate PR)