This repository was archived by the owner on Jun 10, 2020. It is now read-only.
Generate W3C-compatible operation id if there is no request-id header#722
Merged
Generate W3C-compatible operation id if there is no request-id header#722
Conversation
cijothomas
approved these changes
Jul 19, 2018
lmolkova
commented
Jul 23, 2018
| /// https://github.com/w3c/distributed-tracing/blob/master/trace_context/HTTP_HEADER_FORMAT.md#trace-id | ||
| /// </summary> | ||
| /// <returns>Random 16 bytes array encoded as hex string</returns> | ||
| internal static string GenerateTraceId() |
Author
There was a problem hiding this comment.
I've tried to remove this guy and use one from Web SDK StringUtilities. Did not work out: https://github.com/Microsoft/ApplicationInsights-dotnet-server/issues/956, so we'll have to live with copy-paste for a while...
4c0bb62 to
4975794
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See microsoft/ApplicationInsights-dotnet-server#952:
This change should be merged after DependencyCollector beta4 is onboarded (and copy-paste code is removed)