Make QuickPulse configurable by adding it to DI like all other modules#645
Make QuickPulse configurable by adding it to DI like all other modules#645cijothomas merged 6 commits intodevelopfrom
Conversation
…uration of the same by user. QP is enabled by configuring it based on the user supplied flag EnableQuickPulse as before.
|
QP module will be present in DI always even when QP is explicitly disabled by user. However, if disabled, the QP TelemetryProcessor won't be created and added to QPModule. - Net effect is that, if QP is disabled by user, then it will be disabled, though there is a QP module sitting idle in DI. This may/may not be ideal - but this fixes the important issue of 'Not able to configure QP' for immediate term. The full config story will be revisited soon. |
|
I'll send separate PR's to Doc update this doc which is incorrect. |
| } | ||
|
|
||
| [Event(12, Message = "Unable to find expected module {0} in service collection.", Level = EventLevel.Warning, Keywords = Keywords.Diagnostics)] | ||
| public void UnableToFindExpectedModule(string moduleType, string appDomainName = "Incorrect") |
There was a problem hiding this comment.
Can you make this message more specific. So customer will know that without this QuickPulse wouldn't work. Generic message doesn't help.
Also promote it to Error so support of customer screwed up config and not able to see live metrics would be easier
SergeyKanzhelev
left a comment
SergeyKanzhelev
left a comment
There was a problem hiding this comment.
Please change the text to make it easier to support the product. So reading an error person can figure out what's wrong
| this.WriteEvent(11, moduleType, this.ApplicationName); | ||
| } | ||
|
|
||
| [Event(12, Message = "Unable to find QuickPulseTelemetryModule in service collection. QuickPulse/LiveMetrics feature will not be available.", Level = EventLevel.Error, Keywords = Keywords.Diagnostics)] |
There was a problem hiding this comment.
pick a name =) Either quick pulse or Live Metrics. Also suggest a fix, Make it easy to support the product
2 participants
Add QuickPulseTelememodule to DI so as to enable retrieval and configuration of the same by user.
QP is enabled by configuring it based on the user supplied flag EnableQuickPulse as before. But now users can use the extension method services.ConfigureTelemetryModule() to configure QP module.
Fix Issue #639
For significant contributions please make sure you have completed the following items:
Changes in public surface reviewed
Design discussion issue #
CHANGELOG.md updated with one line description of the fix, and a link to the original issue.
The PR will trigger build, unit tests, and functional tests automatically. If your PR was submitted from fork - mention one of committers to initiate the build for you.
If you want to to re-run the build/tests, the easiest way is to simply Close and Re-Open this same PR. (Just click 'close pull request' followed by 'open pull request' buttons at the bottom of the PR)
Please follow [these] (https://github.com/Microsoft/ApplicationInsights-aspnetcore/blob/develop/Readme.md) instructions to build and test locally.