Fix trace toggling for multiple vehicles #4266
Conversation
rajat2004
force-pushed
the
multi-vehicle-trace
branch
from
f8e0ec0 to
cc0922a
Compare
rajat2004
force-pushed
the
multi-vehicle-trace
branch
from
cc0922a to
a22f947
Compare
There was a problem hiding this comment.
Thanks for fixing this this @rajat2004! Tested locally and this works for me just fine. Left one comment about cleaning up the Unity wrapper. Will talk with the team about whether to include this in the next release.
| ImageType getSubwindowCameraType(int window_index); | ||
| void setSubwindowCameraType(int window_index, ImageType type); |
There was a problem hiding this comment.
getSubwindowCameraType, getSubwindowCameraType, getSubwindowVisible, and setSubwindowVisible are also defined here. Is there any reason to not clean up the Unity wrapper as well?
There was a problem hiding this comment.
Main reason was that I currently don't have a working Unity installation, going through that code, none of the subwindow code in Unity SimHUD.cpp seems to be actually used, and the subwindows are created in AirsimHUDScript.cs
Will try to go through it a bit more
There was a problem hiding this comment.
I have a working Unity installation, so I decided to commit this cleanup change after testing that subwindows still functioned normally in my Unity build. Once I get this merged, I'll include it in the next release.
remove unnecessary subwindow helper functions
|
Thanks for submitting this PR @rajat2004! Moving ahead with merging. |
|
Thanks a lot @zimmy87 for the Unity changes! I'll get my old setup working over the weekend, sorry for this |
2 participants
Fixes: #4260
About
Now tracing gets enabled for all the vehicles
TODO
How Has This Been Tested?
Using the
Pythonclient/multirotor/multi_agent_drone.pyscript and settingsScreenshots (if appropriate):