[iOS] Fixed Observer Issue #6878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
licanhua
reviewed
Jan 11, 2022
licanhua
approved these changes
Jan 11, 2022
paulcam206
approved these changes
Jan 11, 2022
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* [ios] updated stack trace * [ios] fixed worngnly incrementing subscriber counts
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* [ios] updated stack trace * [ios] fixed worngnly incrementing subscriber counts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
We have an occasional test failure with IconsInSomeActions.json card. I'm pretty certain that this PR fixes the issue. If not, this PR will fix one of the possible failure paths.
The unit tests do not utilize resource resolvers. There is a small chance where image is loaded very fast, and activate the observer removal path. Because actions have been increasing the subscribers counts without checking if resolver interface is used, it will try to remove the observer, and will cause this exception.
This won't impact sdk users since the users use resource resolvers unlike in unit test scenarios.
Removed dead code that's not used.
Microsoft Reviewers: Open in CodeFlow