Skip to content

Conversation

@almedina-ms
Copy link
Contributor

@almedina-ms almedina-ms commented Jan 4, 2022

Related Issue

Fixes #6128
Fixes #6129
Fixes #6131

Description

  • Adds classes for elements retrieval and interaction
  • Cleans up the already existing tests
  • Fixes Asserts where actual and expected values were mixed
  • Adds more tests for other elements
  • Fixes waits by removing delays
  • Adds support for submit actions data and open url actions on test app

How Verified

Tests were added and run locally

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Jan 4, 2022

Hi @almedina-ms. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@almedina-ms almedina-ms enabled auto-merge (squash) January 10, 2022 18:30
@almedina-ms almedina-ms merged commit 01527e6 into main Jan 10, 2022
@almedina-ms almedina-ms deleted the user/almedina-ms/JS_EnhanceTestingSuite branch January 10, 2022 19:43
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
* Refactor a lot of code

* Fix more tests

* Add support for more elements

* Add more tests for other elements

* Fix toggle input behaviour

* Add test for showcard

* Add more functions

* Last update

* Move setData to input

* Fix build failure

* Resolve small nit

* Update a couple more lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants