Added App extension to podspec #6849

jwoo-msft · 2021-12-14T01:42:14Z

Description

SDK users currently can't choose not including the FluentUI dependency
This change allows it.
Based on Janus'PR created AdpativeCardsCore subspec that doesn't take dependency on FluentUI
Added extension subspec that takes FluentUI
Added CPP macro to enable extension via proprocessor macro.
the pattern is well documented in this thread and a blog post
Added the macro to sample project as it doesn't consume pod.

How Verified

Tested it with Sample app with the extension.
Janus tested without extension.

Microsoft Reviewers: Open in CodeFlow

updated spec added podspec at root for testing\n revert it spec updated updated pod spec pod spec update moretesting [updated macro name]

source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards.xcodeproj/project.pbxproj

source/ios/tools/AdaptiveCards.podspec

source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRBaseTarget.mm

source/ios/tools/AdaptiveCards.podspec

almedina-ms

beervoley

ADAPTIVECARDS_APP_EXTENSION may not be the best name because in this case it only affects FLUENT_TOOLTIPS and if we add more features that host should be able to disable independently, it's going to be a mess :)

jwoo-msft · 2021-12-14T19:59:07Z

Member

jwoo-msft · 2021-12-14T20:01:52Z

Member

No, it's not. We are going to add an extension library on top of this and will remove the flag when we add more controls.

beervoley

I will approve, but the naming still doesn't make much sense to me :)

jwoo-msft · 2021-12-14T20:17:25Z

I will approve, but the naming still doesn't make much sense to me :)

I changed the name.

beervoley · 2021-12-14T20:37:21Z

I will approve, but the naming still doesn't make much sense to me :)

I changed the name.

thanks Joseph :)

* app extension model added updated spec added podspec at root for testing\n revert it spec updated updated pod spec pod spec update moretesting [updated macro name] * updated podspec * [ios] Updated to final podspec version * update compiler flag * pod spec update * updated flag name

* Added App extension to podspec (#6849) * app extension model added updated spec added podspec at root for testing\n revert it spec updated updated pod spec pod spec update moretesting [updated macro name] * updated podspec * [ios] Updated to final podspec version * update compiler flag * pod spec update * updated flag name * [iOS] fixed empty filtered list issue (#6528) * [iOS] fixed empty filtered list issue * [iOS] changed to function call Co-authored-by: Canhua Li <[email protected]> * moving resource bundle to core (#6853) Co-authored-by: Janus Balatbat <[email protected]> * Rounding off to 2 decimals (#6863) * [ios] updated round off logic (#6866) * [ios] updated round off logic * [ios] refactored the code * [ios] fixed project file * [ios] fixed log * [ios] spec updated * update test (#6864) * added heartbeat test ios build infrastructure (#6842) * [iOS] added yml version of ci updated path [ios] path update [iOS] variable updated [ios] added new test scheme * [iOS] added spec linting task added missing test file updated spect lint task added error handling added parallelism to jobs * added cert test added cert install yml updated pass Update ios-heartbeat.yml for Azure Pipelines added provisional file added script unimportant commit unimportant commit unimportant commit * added e-mail message simple update added e-mail message added e-mail message added e-mail message updated e-mail message updated e-mail message updated e-mail message * updated cron job * added false test Revert "added false test" This reverts commit ef302f0. * added false test added build task to cert task added build task to cert task added build task to cert task good cert bad prov added app push * parameterized template updated parameters updated params updated parameters updated to correct provisional file * updated trigger * updated e-mail address Co-authored-by: Canhua Li <[email protected]> Co-authored-by: janusbal <[email protected]> Co-authored-by: Janus Balatbat <[email protected]> Co-authored-by: shabripabba <[email protected]>

* Added App extension to podspec (#6849) * app extension model added updated spec added podspec at root for testing\n revert it spec updated updated pod spec pod spec update moretesting [updated macro name] * updated podspec * [ios] Updated to final podspec version * update compiler flag * pod spec update * updated flag name * [iOS] fixed empty filtered list issue (#6528) * [iOS] fixed empty filtered list issue * [iOS] changed to function call Co-authored-by: Canhua Li <[email protected]> * moving resource bundle to core (#6853) Co-authored-by: Janus Balatbat <[email protected]> * Rounding off to 2 decimals (#6863) * [ios] updated round off logic (#6866) * [ios] updated round off logic * [ios] refactored the code * [ios] fixed project file * [ios] fixed log * [ios] spec updated * update test (#6864) * added heartbeat test ios build infrastructure (#6842) * [iOS] added yml version of ci updated path [ios] path update [iOS] variable updated [ios] added new test scheme * [iOS] added spec linting task added missing test file updated spect lint task added error handling added parallelism to jobs * added cert test added cert install yml updated pass Update ios-heartbeat.yml for Azure Pipelines added provisional file added script unimportant commit unimportant commit unimportant commit * added e-mail message simple update added e-mail message added e-mail message added e-mail message updated e-mail message updated e-mail message updated e-mail message * updated cron job * added false test Revert "added false test" This reverts commit ef302f0. * added false test added build task to cert task added build task to cert task added build task to cert task good cert bad prov added app push * parameterized template updated parameters updated params updated parameters updated to correct provisional file * updated trigger * updated e-mail address * Bug fixes: Textblock layout | Parsing warnings (#7041) * need to take accoutn for empty * works but need to find memory leak * testing against stackedit * removing unneeded line | allocating array * clean up * getting rid of str() use from strigstream * handling link destination with [ character and other tokens * removing cpp changes Co-authored-by: Janus Balatbat <[email protected]> * Bug fixes: Handling of link markdown (#6922) * need to take accoutn for empty * works but need to find memory leak * testing against stackedit * removing unneeded line | allocating array * clean up * getting rid of str() use from strigstream * handling link destination with [ character and other tokens * removing the ios changes * resolving comments * resolving comments * clan format Co-authored-by: Janus Balatbat <[email protected]> * updated android-ci yml to use latest macOs Co-authored-by: Canhua Li <[email protected]> Co-authored-by: janusbal <[email protected]> Co-authored-by: Janus Balatbat <[email protected]> Co-authored-by: shabripabba <[email protected]>

* app extension model added updated spec added podspec at root for testing\n revert it spec updated updated pod spec pod spec update moretesting [updated macro name] * updated podspec * [ios] Updated to final podspec version * update compiler flag * pod spec update * updated flag name

jwoo-msft added 3 commits December 13, 2021 17:32

app extension model added

97d1b8b

updated spec added podspec at root for testing\n revert it spec updated updated pod spec pod spec update moretesting [updated macro name]

updated podspec

10c6552

[ios] Updated to final podspec version

95ddaff

beervoley reviewed Dec 14, 2021

View reviewed changes

source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved

beervoley reviewed Dec 14, 2021

View reviewed changes

source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved

update compiler flag

0f01da3

beervoley reviewed Dec 14, 2021

View reviewed changes

source/ios/tools/AdaptiveCards.podspec Show resolved Hide resolved

beervoley reviewed Dec 14, 2021

View reviewed changes

source/ios/tools/AdaptiveCards.podspec Outdated Show resolved Hide resolved

licanhua reviewed Dec 14, 2021

View reviewed changes

source/ios/tools/AdaptiveCards.podspec Show resolved Hide resolved

source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRBaseTarget.mm Outdated Show resolved Hide resolved

pod spec update

aeaa2a1

licanhua approved these changes Dec 14, 2021

View reviewed changes

beervoley approved these changes Dec 14, 2021

View reviewed changes

dclaux reviewed Dec 14, 2021

View reviewed changes

source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRBaseTarget.mm Outdated Show resolved Hide resolved

almedina-ms reviewed Dec 14, 2021

View reviewed changes

source/ios/tools/AdaptiveCards.podspec Outdated Show resolved Hide resolved

almedina-ms approved these changes Dec 14, 2021

View reviewed changes

beervoley requested changes Dec 14, 2021

View reviewed changes

ghost added the Needs: Author Feedback label Dec 14, 2021

jwoo-msft closed this Dec 14, 2021

ghost removed the Needs: Author Feedback label Dec 14, 2021

jwoo-msft reopened this Dec 14, 2021

beervoley approved these changes Dec 14, 2021

View reviewed changes

updated flag name

1b13282

jwoo-msft force-pushed the jwoo/ios-fluent-ui-sep branch from aab655e to 1b13282 Compare December 14, 2021 20:16

Merge branch 'main' into jwoo/ios-fluent-ui-sep

6d1051e

jwoo-msft enabled auto-merge (squash) December 14, 2021 20:17

jwoo-msft merged commit b813d37 into main Dec 14, 2021

jwoo-msft deleted the jwoo/ios-fluent-ui-sep branch December 14, 2021 20:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added App extension to podspec #6849

Added App extension to podspec #6849

Uh oh!

jwoo-msft commented Dec 14, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

almedina-ms left a comment

Uh oh!

beervoley left a comment

Uh oh!

jwoo-msft commented Dec 14, 2021

Uh oh!

jwoo-msft commented Dec 14, 2021

Uh oh!

beervoley left a comment

Uh oh!

jwoo-msft commented Dec 14, 2021

Uh oh!

beervoley commented Dec 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Added App extension to podspec #6849

Added App extension to podspec #6849

Uh oh!

Conversation

jwoo-msft commented Dec 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Verified

Microsoft Reviewers: Open in CodeFlow

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

almedina-ms left a comment

Choose a reason for hiding this comment

Uh oh!

beervoley left a comment

Choose a reason for hiding this comment

Uh oh!

jwoo-msft commented Dec 14, 2021

Uh oh!

jwoo-msft commented Dec 14, 2021

Uh oh!

beervoley left a comment

Choose a reason for hiding this comment

Uh oh!

jwoo-msft commented Dec 14, 2021

Uh oh!

beervoley commented Dec 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jwoo-msft commented Dec 14, 2021 •

edited

Loading