Skip to content

[UWP] Fix risky cast in GenerateElementProjection() #6412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 28, 2021
Merged

[UWP] Fix risky cast in GenerateElementProjection() #6412

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4b92e0
[UWP] Fix risky cast in `GenerateElementProjection()`
paulcam206 Sep 26, 2021
95196d9
Merge branch 'main' into paulcam/fix-uwp-elemproj
paulcam206 Sep 28, 2021
33ef1ef
Merge branch 'main' into paulcam/fix-uwp-elemproj
paulcam206 Sep 28, 2021
cfbe6dc
Fix PR feedback
paulcam206 Sep 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions source/uwp/AdaptiveCardsObjectModel/lib/ObjectModelUtil.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,13 +307,17 @@ winrt::AdaptiveCards::ObjectModel::Uwp::IAdaptiveCardElement GenerateElementProj
case CardElementType::Table:
return winrt::make<winrt::AdaptiveCards::ObjectModel::Uwp::implementation::AdaptiveTable>(
std::AdaptivePointerCast<AdaptiveCards::Table>(baseElement));
break;
case CardElementType::Custom:
return std::AdaptivePointerCast<::AdaptiveCards::ObjectModel::Uwp::CustomElementWrapper>(baseElement)->GetWrappedElement();
case CardElementType::Unknown:
default:
return winrt::make<winrt::AdaptiveCards::ObjectModel::Uwp::implementation::AdaptiveUnsupportedElement>(
std::AdaptivePointerCast<AdaptiveCards::UnknownElement>(baseElement));
default:
// It should not be possible for an element represented by a CardElementType to not have a matching case here.
// Either a new element has been introduced in the shared model without full support here in UWP, or there's a
// bug in the shared model (see https://github.com/microsoft/AdaptiveCards/issues/6393).

throw winrt::hresult_error(E_UNEXPECTED, L"CardElementType not supported");
}
}

Expand Down