[Designer] Make everything accessible at high zoom levels #6320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcam206
added
Area-Accessibility
paulcam206
requested review from
RebeccaAnne,
almedina-ms,
dclaux,
jonmill,
jwoo-msft and
matthidinger
|
Hi @paulcam206. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes. |
paulcam206
changed the title
dclaux
reviewed
Sep 14, 2021
Member
There was a problem hiding this comment.
Looks good overall, however:
- In "mini" mode, dragging a new element onto the card makes the card basically disappear. I believe this happens because the associated item in the treeview is forced into view, which works with the normal layout but not when all panes are stacked on top of each other
- You apparently have the threshold set to 501px horizontally, but the designer starts being unusable well before that. Would it make sense to change the threshold to something a little higher?
RebeccaAnne
reviewed
Sep 14, 2021
source/nodejs/adaptivecards-site/themes/adaptivecards/layout/designer.ejs
Outdated
Show resolved
Hide resolved
RebeccaAnne
approved these changes
Sep 14, 2021
paulcam206
force-pushed
the
paulcam/designer-pass-small-screen
branch
from
b367aa8 to
9961ca2
Compare
Member
Author
the scroll-in-to-view fix was pretty easy, but the drag/drop overlay fix was a little gnarly (there was some math that didn't account for scroll position (because there wasn't a need to before)).
I set it to 651px since that's about as small as you can go and still sort of use everything... |
jwoo-msft
approved these changes
Sep 22, 2021
vivekkozhisseri
pushed a commit
to BigThinkcode/AdaptiveCards
that referenced
this pull request
Sep 30, 2021
* Toggle input in c++/winrt! (microsoft#6303) * Toggle input in c++/winrt! * PR Feedback * Fix return value * Merge Jonwis' object model conversion into UWP (microsoft#6322) * Merge u/jonwis/winui3 from fork * Copy object model changes from winappsdk to uwp * Delete winappsdk directory * Rename WinUI3 to Uwp - everything builds * Testing, bug fixes, and cleanup * Fix propert_opt setter * Version and package changes * Remove nuget source from nuget config * version changes * Update package pushing readme Co-authored-by: Jon Wiswall <[email protected]> Co-authored-by: almedina-ms <[email protected]> * [Designer] Make everything accessible at high zoom levels (microsoft#6320) * [Designer] Make small-x-dimension scenario basically work Fixes microsoft#6263 * Tabs feedback * Fix drag/drop and random scrolling * Per triage, Xamarin is deprecated, so no need to hold on to this old unsupported code (microsoft#6255) * [Shared] Add `password` `Input.Text` support (microsoft#6377) * [Shared] Add `password` `Input.Text` support Fixes microsoft#6340 * PR feedback * [iOS] removed custom background color to return to system default (microsoft#6378) * [iOS] Updated Radio Buttons / Check Boxes Contrast Ratio (microsoft#6372) Co-authored-by: Paul Campbell <[email protected]> * Set wrapping to true for accessibility fix (microsoft#6324) Co-authored-by: Paul Campbell <[email protected]> * Fix link traversal (microsoft#6317) Co-authored-by: Paul Campbell <[email protected]> * [iOS] Updated vertical content alignment, height and toggle Visibility (microsoft#6329) * [iOS] Fixed microsoft#6219 * [iOS] adding padding support to toggle visibility * [Padding] Update * [iOS] work in progress * mostly done need to refactor and update padding management code * [iOS] refactored * [iOS] added padding test * refactored the padding configuration in FactSet to Padding Handler * [iOS] Updated VerticalContentAlignment and Height * Reverts samples card changes * [iOS] code clean-up * [iOS] CR update * [iOS] CR update * Add implementation and tests (microsoft#6406) Co-authored-by: Paul Campbell <[email protected]> * [UWP] Fix risky cast in `GenerateElementProjection()` (microsoft#6412) * [UWP] Fix risky cast in `GenerateElementProjection()` Fixes microsoft#6394 * Fix PR feedback * Fix style behaviour (microsoft#6419) Co-authored-by: Paul Campbell <[email protected]> * [JS] Add Password support to Input.Text (microsoft#6407) * Add Password to style list * Fix comparator * Change property implementation to contain version info in new enum value Co-authored-by: Paul Campbell <[email protected]> * [iOS] Password Masking (microsoft#6411) * [iOS] Password implementation * [iOS] Updated unit tests and added sample json * Update Input.Text.PasswordStyle.json Co-authored-by: almedina-ms <[email protected]> * [iOS] Table Horizontal Alignment Update (microsoft#6401) * [iOS] Fixed microsoft#6219 * [iOS] adding padding support to toggle visibility * [Padding] Update * [iOS] work in progress * mostly done need to refactor and update padding management code * [iOS] refactored * [iOS] added padding test * refactored the padding configuration in FactSet to Padding Handler * [iOS] Updated VerticalContentAlignment and Height * Reverts samples card changes * [iOS] code clean-up * [iOS] Table Update * [iOS] Updated Table with better Horizontal Alignment Co-authored-by: Paul Campbell <[email protected]> * [iOS/Android/UWP/Shared] Fix handling of orphaned table child elements (microsoft#6408) * [Shared] Fix parsing of `TableRow` and `TableCell` outside of `Table` Fixes microsoft#6393 * SWIG updates * Fix up Android rendering * Fix up iOS * Fix up UWP Co-authored-by: Paul Campbell <[email protected]> * Enabling blank issues for internal team use (microsoft#6445) Co-authored-by: RebeccaAnne <[email protected]> Co-authored-by: Jon Wiswall <[email protected]> Co-authored-by: almedina-ms <[email protected]> Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: Joseph Woo <[email protected]> Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: Jonathan Miller <[email protected]>
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
…6320) * [Designer] Make small-x-dimension scenario basically work Fixes microsoft#6263 * Tabs feedback * Fix drag/drop and random scrolling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #6263
Description
A bevy of fixes for the designer on small screens. Pushes a bunch of runtime-defined CSS styles into classes so that they can be overridden by media queries at render time. Below 500px width, we shift to a vertical scroll model which, while not ideal from a usability perspective, at least allows the user to access all of the content, which was not possible before. Having a more usable experience is something that will require design resources which we'll have to engage at a later time (see #6313).
Screenshots
Before
Main
(note: no scrollbars)
New Card Dialog
(large margins)
After
Main
New Card Dialog
How Verified
Manual testing
Microsoft Reviewers: Open in CodeFlow