Skip to content

Add Analytics demo data module #28860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Add Analytics demo data module #28860

wants to merge 16 commits into from

Conversation

@tuan-nguyen-fenwick
Copy link

@tuan-nguyen-fenwick tuan-nguyen-fenwick commented Jul 10, 2025 •
edited by github-actions bot
Loading

Summary

  • Added a new module for Analytics to populate more sales & purchase documents for the Power BI reports and the modernized sales reports.

Work Item(s)

Fixes #28859
Fixes: AB#580998

Tuan Nguyen added 5 commits June 26, 2025 15:20
Created Analytics module & added data creation for analytics
9447e7d
Added purchase document creation for analytics
7d816c6
Added Analytics Module Setup table & page for relative starting date
9de60c3
Generate document dates from a starting date instead of hardcoding th…
82a5fd4 
…e dates
Merged PR 35992: Added Analytics module for sales analytics data
864d3e6 
![image (3).png](https://dev.azure.com/fenwick/bf100862-1f7e-4467-bf86-526d4c7ac7eb/_apis/git/repositories/bc6a2808-2da7-4039-8a77-6283538e4d5d/pullRequests/35992/attachments/image%20%283%29.png)

![image (2).png](https://dev.azure.com/fenwick/bf100862-1f7e-4467-bf86-526d4c7ac7eb/_apis/git/repositories/bc6a2808-2da7-4039-8a77-6283538e4d5d/pullRequests/35992/attachments/image%20%282%29.png)

Test container: http://bcdev2.fenwicksoftware.com.au:10260/BC/?company=Demo%20Data%206

Related work items: microsoft#27654
@tuan-nguyen-fenwick tuan-nguyen-fenwick requested a review from a team as a code owner July 10, 2025 04:56
@JesperSchulz
Copy link
Contributor

JesperSchulz commented Jul 10, 2025

We've been receiving some push back on the demo data PRs. Will ask for a review by the team behind the demo data tool before processing.
@haoranpb, could you take a look?

@JesperSchulz JesperSchulz requested a review from haoranpb July 10, 2025 10:26
@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Jul 10, 2025
haoranpb
haoranpb reviewed Jul 10, 2025
View reviewed changes
@github-actions github-actions bot added the linked Issue is linked to a Azure Boards work item label Jul 15, 2025
haoranpb
haoranpb requested changes Jul 16, 2025
View reviewed changes
@tuan-nguyen-fenwick
Copy link
Author

tuan-nguyen-fenwick commented Aug 1, 2025

@haoranpb Just checking in to see whether you have any more feedback on this PR? Thank you

haoranpb
haoranpb previously approved these changes Aug 4, 2025
View reviewed changes
PredragMaricic
PredragMaricic previously approved these changes Aug 12, 2025
View reviewed changes
@JesperSchulz JesperSchulz self-assigned this Aug 13, 2025
@JesperSchulz JesperSchulz added the processing-PR The PR is currently being reviewed label Aug 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2025

Processing this PR. The branch is now locked 🔒 Please don't push updates unless otherwise agreed.

JesperSchulz
JesperSchulz reviewed Aug 13, 2025
View reviewed changes
Apps/W1/ContosoCoffeeDemoDataset/app/DemoTool/ContosoDemoDataModule.Enum.al
using Microsoft.DemoData.Sales;
using Microsoft.DemoData.Service;
using Microsoft.DemoData.Warehousing;
using Microsoft.DemoData.Analytics;
Copy link
Contributor

@JesperSchulz JesperSchulz Aug 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to not exist. Is there a specific order in which I need to process the PRs?

@tuan-nguyen-fenwick
Copy link
Author

tuan-nguyen-fenwick commented Aug 18, 2025

@ayrtonmassey Could you review this PR please? Thank you

@ayrtonmassey ayrtonmassey removed their request for review August 18, 2025 09:43
@ayrtonmassey
Copy link

ayrtonmassey commented Aug 18, 2025

@tuan-nguyen-fenwick I'm not sure why I was added to this PR, I have removed myself.

Looks like you have some comments from @JesperSchulz to resolve?

@JesperSchulz
Copy link
Contributor

JesperSchulz commented Aug 20, 2025

Please disregard the random assignment of code reviewers. Not sure why GitHub does that.

@WaelAbuSeada, we need your review of this one.

WaelAbuSeada
WaelAbuSeada requested changes Aug 25, 2025
View reviewed changes
...feeDemoDataset/app/DemoData/Analytics/3.Transactions/CreateExtendedPurchDocument.Codeunit.al Outdated
end;

var
AnalyticsReferenceTok: Label 'ANALYTICS', Locked = true;
Copy link
Member

@WaelAbuSeada WaelAbuSeada Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be locked?

@tuan-nguyen-fenwick
Copy link
Author

tuan-nguyen-fenwick commented Aug 27, 2025

@WaelAbuSeada I have addressed build issues in IT:

image

@JesperSchulz JesperSchulz removed their assignment Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JesperSchulz JesperSchulz JesperSchulz left review comments

@WaelAbuSeada WaelAbuSeada WaelAbuSeada requested changes

@haoranpb haoranpb haoranpb left review comments

@PredragMaricic PredragMaricic PredragMaricic left review comments

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Integration GitHub request for Integration area linked Issue is linked to a Azure Boards work item processing-PR The PR is currently being reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Analytics demo data module

6 participants

@tuan-nguyen-fenwick @JesperSchulz @ayrtonmassey @haoranpb @PredragMaricic @WaelAbuSeada