-
Notifications
You must be signed in to change notification settings - Fork 602
updated .travis.yml to specify go 1.7.5 #47
Conversation
|
Well, the test failed, but maybe because I ran against my own fork? The problem seems to be with the dockertest command: scripts/testcontainer.sh |
|
I think the testcontainer.sh failed because the sleep was not long enough. On my laptop, when I ran the test it also failed, but I noticed the containers were still running. So, I tried running the testcontainer.sh script and it was successful. So, I increased the sleep in that file from 2 to 10 seconds and will close and re-open this pull request so that the test is run again. |
|
Re-opening to see if sleep of 10 seconds helps. |
|
The build seem to have stalled out eventually, but note that setting the sleep to 10 seconds in testcontainer.sh DID allow that script to succeed. After that, I saw: and eventually: No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. I will re-open and force another build. |
|
Note that the last thing before the message about waiting 10 minutes is: docker login -u -p I think the build failure is probably ok and merely reflects that I don't have the DOCKER_PASS variable set. I presume if you guys run it, you will have that set and the test will complete successfully. |
|
Why is the sleep moved to 10? @rberlind |
|
Hi Richard, |
jasonrichardsmith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Setting go version in travis file did the trick. |
I edited .travis.yml to specify go 1.7.5 since I think this might be needed to actually use Go 1.7.5 in the user app on the Docker images despite https://github.com/microservices-demo/user/blob/master/Dockerfile being built from golang:1.7-alpine which currently already uses Go 1.7.5. This is in connection with #46.
Thanks.