feature: micronaut test netty leak #2886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yawkat
reviewed
Oct 20, 2025
|
|
||
| import java.util.Set; | ||
|
|
||
| @Requires(property = "micronaut.starter.feature.micronaut-test-netty-leak.enabled", value = StringUtils.TRUE, defaultValue = StringUtils.TRUE) |
Member
There was a problem hiding this comment.
i dont think this is useful enough for most people to become a default
Contributor
Author
There was a problem hiding this comment.
we add this @Requires for every feature. It enables users to disable the feature.
Member
|
I think we also need some code to enable extension detection for junit 5? |
The test sees two files: - starter-web-netty - test-suite-graal It seems GraalVM test is picking the one in starter-web-netty instead of one test-suite-graal
Contributor
Author
I created a https://docs.junit.org/current/user-guide/#extensions-registration-automatic-enabling |
yawkat
reviewed
Oct 20, 2025
starter-core/src/main/java/io/micronaut/starter/feature/test/MicronautTestNettyLeak.java
Outdated
Show resolved
Hide resolved
yawkat
approved these changes
Oct 21, 2025
github-project-automation
bot
moved this from Ready for Review
to Done
in 4.10.0 Release
Member
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds feature for micronaut-projects/micronaut-test#1291