Use reactor bom, removed netty-http dependency#669
Merged
Conversation
radovanradic
commented
Aug 16, 2024
|
radovanradic
commented
Sep 2, 2024
|
|
||
| api(libs.managed.reactor.netty.http) | ||
|
|
||
| api(platform(mnReactor.boms.reactor)) |
Contributor
Author
There was a problem hiding this comment.
@sdelamo This PR is now passing and it would be good if we can use it. Then we would not need this in micronaut-data https://github.com/micronaut-projects/micronaut-data/pull/3070/files#diff-697f70cdd88ba88fe77eebda60c7e143f6ad1286bca75017421e93ad84fb87dfR99
Before this change, we had netty-reactor dependencies coming via mariadb dependencies. And adding to micronaut-data just fixed issue we noticed in tests, but other users might need it too so it is better have api dependency in r2dbc than in data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of #667