Smarter processing of javadoc comments into OpenAPI documentation#761
Merged
graemerocher merged 3 commits intomicronaut-projects:masterfrom Jul 11, 2022
altro3:javadoc_parser
Merged
Smarter processing of javadoc comments into OpenAPI documentation#761graemerocher merged 3 commits intomicronaut-projects:masterfrom altro3:javadoc_parser
graemerocher merged 3 commits intomicronaut-projects:masterfrom
altro3:javadoc_parser
Conversation
Contributor
|
Wow this is pretty nice 🤩 Could you resolve the conflicts? |
graemerocher
changed the title
Collaborator
Author
|
@graemerocher but for full support need these changes: micronaut-projects/micronaut-core#7662 I hope you include this pull request in the 3.6.0 release. |
… method javadoc. Add support html tags which will be convert to markdown. Add support Operation internal parameters field. Fix problem with set style for parameter Add read class level javadoc (need to records, kotlin data classes and enums) Fixes #265
Collaborator
Author
|
@graemerocher conflicts resolved :-) |
alvarosanchez
approved these changes
Jul 11, 2022
| /** | ||
| * Some util methods. | ||
| */ | ||
| public class Utils { |
Member
There was a problem hiding this comment.
Few small suggestions:
- add
@sincetag please. I guess this will go in a 4.4.0 version of this module. - this class should be final.
- it should have a private empty default constructor
Contributor
|
Thanks for the contribution! Are these all your changes and can we do a 4.4.0 release? Thanks for all your work on this, it makes a big difference to the community! |
Collaborator
Author
|
@graemerocher You are welcome! :-) Yes, I think this is more than enough for the release. I will be able to make the following changes only over the weekend, but this will not be included in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor JavadocParser.
Add support summary and description blocks in method javadoc.
Add support html tags which will be convert to markdown
Add support Operation internal parameters field.
Fix problem with set style for parameter
Add read class level javadoc (need to records, kotlin data classes and enums)
Fixes #265