Fixes invalid Baggage propagation for W3C with Brave #71
Conversation
without this change we've managed to successfully parse the request and create baggage entries, however they got then lost when new scopes were opened with this change we're using the native Brave mechanism for BaggageField creation however we're updating the existing BaggageFields values when using the BravePropagator
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { |
There was a problem hiding this comment.
EqualsGetClass: Prefer instanceof to getClass when implementing Object#equals.
| public boolean equals(Object o) { | |
| if (!(o instanceof BraveBaggageFields)) { |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| private void updateExistingBaggageFieldsWithUpdatedValues(TraceContextOrSamplingFlags extract) { | ||
| List<Object> extra = extract.context().extra(); |
There was a problem hiding this comment.
NULL_DEREFERENCE: object returned by extract.context() could be null and is dereferenced at line 69.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
marcingrzejszczak
deleted the
fixesInvalidW3CBaggagePropagationWithBrave
branch
without this change we've managed to successfully parse the request and create baggage entries, however they got then lost when new scopes were opened with this change we're using the native Brave mechanism for BaggageField creation however we're updating the existing BaggageFields values when using the BravePropagator