Add getAll to Getter for repeated metadata #6312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
force-pushed
the
get-all-the-things
branch
2 times, most recently
from
b67c73d to
64cf633
Compare
shakuzen
force-pushed
the
get-all-the-things
branch
2 times, most recently
from
6ab417f to
babdbc5
Compare
shakuzen
changed the title
It's known that some metadata can be repeated on a carrier. W3C baggage is one example of this in HTTP request headers. The current get API returns a String, and for performance reasons we may not want to check all headers to combine repeated headers when we don't expect there should be repeated headers. This updates the one non-deprecated main code implementation of Getter (in ObservationGrpcServerInterceptor) to implement the new getAll method.
shakuzen
force-pushed
the
get-all-the-things
branch
from
babdbc5 to
7ca0c2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's known that some metadata can be repeated on a carrier. W3C baggage is one example of this in HTTP request headers. The current get API returns a String, and for performance reasons we may not want to check all headers to combine repeated headers when we don't expect there should be repeated headers.
See micrometer-metrics/tracing#1032