Added support for @MeterTag annotation on method level
#5827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinaMoiseenko
force-pushed
the
create-tags-based-on-method-result-2
branch
from
8a4cc08 to
0caa68f
Compare
shakuzen
approved these changes
Jan 28, 2025
Member
shakuzen
left a comment
shakuzen
left a comment
There was a problem hiding this comment.
Looks good to me. I left some minor review comments we can probably handle as polish when merging.
micrometer-core/src/main/java/io/micrometer/core/aop/CountedAspect.java
Outdated
Show resolved
Hide resolved
...les-spring-framework6/src/test/java/io/micrometer/samples/spring6/aop/CountedAspectTest.java
Outdated
Show resolved
Hide resolved
shakuzen
changed the title
@MeterTag annotation on method level
Signed-off-by: Marina Moiseenko <[email protected]>
shakuzen
force-pushed
the
create-tags-based-on-method-result-2
branch
from
0caa68f to
e02515e
Compare
izeye
added a commit
to izeye/micrometer
that referenced
this pull request
Feb 20, 2025
Signed-off-by: Johnny Lim <[email protected]>
Merged
jonatan-ivanov
pushed a commit
that referenced
this pull request
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3058
re-created pr with new branch, as failed to rebase initial one