Throw exception in case of invalid Observations with TestObservationRegistry #5307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatan-ivanov
commented
Jul 16, 2024
...ion-test/src/test/java/io/micrometer/observation/tck/TestObservationRegistryAssertTests.java
Show resolved
Hide resolved
shakuzen
approved these changes
Jul 17, 2024
Member
shakuzen
left a comment
shakuzen
left a comment
There was a problem hiding this comment.
Looks good to me. I wonder if we should update our tests (ObservationValidatorTests) to not use a custom consumer now so we're testing the same way our users will be affected by the ObservationValidator.
...meter-observation-test/src/main/java/io/micrometer/observation/tck/ObservationValidator.java
Show resolved
Hide resolved
jonatan-ivanov
force-pushed
the
observation-validator-throws-exception
branch
from
68a50d4 to
12a6759
Compare
shakuzen
changed the title
jonatan-ivanov
added
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.