Service level objectives support on @Timed annotation
#5145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
requested changes
Jul 4, 2024
Member
shakuzen
left a comment
shakuzen
left a comment
There was a problem hiding this comment.
Thanks for the pull request. Would you please add test cases showing the Timer created from the TimedAspect and Timer builder method have the SLOs given in the annotation?
Member
|
Could you also look into the TimedAspectTest failures? |
Contributor
Author
|
@shakuzen Thanks for taking a look, will do as soon as I can |
lcavadas
force-pushed
the
timed-annotation-slos-support
branch
from
9b5ffa5 to
1485ba1
Compare
shakuzen
changed the title
@Timed annotation
shakuzen
approved these changes
Jul 9, 2024
izeye
added a commit
to izeye/micrometer
that referenced
this pull request
Sep 11, 2024
izeye
added a commit
to izeye/micrometer
that referenced
this pull request
Sep 11, 2024
Merged
izeye
added a commit
to izeye/micrometer
that referenced
this pull request
Sep 11, 2024
izeye
added a commit
to izeye/micrometer
that referenced
this pull request
Sep 11, 2024
Contributor
|
The "enhancement" label seems to be missing for this, and an entry for this is also missing from the release notes for 1.14.0-M1. |
Member
|
Thank you, I fixed them. |
jonatan-ivanov
pushed a commit
that referenced
this pull request
Sep 11, 2024
jonatan-ivanov
pushed a commit
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to specify, on
@Timedannotations, the service level objectives.Using seconds as the unit of time for these values.