Events in DocumentedObservation

[marcingrzejszczak]

No description provided.

[jonatan-ivanov]

Are you sure that this can be null here?

[marcingrzejszczak]

Yeah I mean look at line 60, we literally null the name

[jonatan-ivanov]

I get that a DocumentedObservation's getName() can return null for filtering purposes but if I take a step back, that might be valid for the DocumentedObservation but I think SimpleObservation should not accept null here. What should the meter handler or the tracing handler do in that case?

Also, DocumentedObservation has a null-check so that nullability behavior can be isolated there I guess.

[marcingrzejszczak]

@cppwfs this might break task cause afair you're using events already. You'll need to change new Observation.Event(...) to Observation.Event.of(...)