Skip to content

Conversation

@mkolegan
Copy link

@mkolegan mkolegan commented Oct 7, 2025

System profile was not read from xml because the logic fallbacks to realData.

In addition to PROFILE_USER and built-in resource-based profiles we need to check PROFILE_SYSTEM

System profile was not read from xml because the logic fallback to realData getProfileResId() was returning 0 in that case.

In addition to PROFILE_USER and built-in resource-based profiles  we need to check PROFILE_SYSTEM
@ale5000-git
Copy link
Member

@mar-v-in
I wonder, could we put these checks directly inside getProfileResId, so the caller doesn't have to care?
To avoid future problems.

@mar-v-in mar-v-in merged commit 0c4b501 into microg:master Dec 10, 2025
1 check passed
@mar-v-in
Copy link
Member

Thanks @mkolegan

@ale5000-git getProfileResId really only does that (getting the ressource id of the profile if it is a built-in profile). One could probably also check for hasProfile() here instead, but for now this solution is safe and works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants