Skip to content

Conversation

@cliechty
Copy link
Contributor

@cliechty cliechty commented Nov 3, 2014

The issue:

  • Given a collection that renders 10 pages
  • and maxSize= 5
  • and displaying page in the upper range of pages (8 for example)
  • The page range shows: 1, ..., 8, 9, 10
  • When an item is removed from collection
  • Then the page range shows: 1, 2, 3, ..., 10 with current page still set to 8
  • It should still show the page range: 1, ..., 8, 9, 10

michaelbromley added a commit that referenced this pull request Nov 4, 2014
dirPagination: Fix page controls listing incorrect page range when collection size changes
@michaelbromley michaelbromley merged commit baa6ef7 into michaelbromley:master Nov 4, 2014
@michaelbromley
Copy link
Owner

Thanks for the excellent pull request!

Yes, I could reproduce the issue you describe and your fix works well. You are also the first person to make a PR to this repo with a unit test for your change, so I award you 1,000 programming points. Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants