Allow the dirPaginationControls/dirPaginate to appear in any order.

[fpipita]

Hi Michael,

for layout reasons, I wanted to place the pagination controls directive before the dirPaginate one, but with the current implementation this is not allowed.

I wanted to ask you whether there is some particular reason why you decided to check for the existence of the related dirPaginate directive at the dirPaginationControls's linking stage rather than doing somewhere else after that the directive has been linked. I think that the latter approach would be more flexible.

Thank you for your time,
Francesco

[michaelbromley]

Hi,

I am able to put the controls before the paginated list in this Plunker demo: http://plnkr.co/edit/Edp7nWE9y06nXymGlMqk?p=preview

It seems to work fine. Can you show me you code where it does not work? Or make a demo I can try out?

[fpipita]

Hi Michael,

here is a simple Plunker that reproduces my use case:

http://plnkr.co/edit/qFtWfDirPB4bMEFmmFej?p=preview

[michaelbromley]

Thanks for that - that makes sense now why it doesn't work in your case.

The issue, I think, is not that the check for the related dirPaginate directive is performed in the paginationControl's linking stage. Rather, it is that the dirPaginate directive doesn't register itself until it's own linking stage, which in the case of you ngSwitch template, will not be called until the switch case becomes true.

From playing around with the demo, it looks like the problem can be solved by moving the paginationService.registerInstance(paginationId); call up into the compile function of the dirPaginte directive. In this way, it will get registered as soon as the directive is encountered, regardless of whether it is being linked now or later.

Here is a demo with this change: http://plnkr.co/edit/hw4tfpFJQcAZP0OJUDWV?p=preview

Now, however, we get a new (non-fatal) error to do with trying to get the current page when it has not yet been defined.

I'll figure out the full fix and make sure it doesn't break the existing tests, and publish a patch shortly.

[michaelbromley]

Okay, that's done now. Thanks for the report.

[fpipita]

Thank you for the quick fix.

Are you going to push a new release of the Bower package including the fix anytime soon?

[michaelbromley]

Yeah, just done that now. Happy updating!

[fpipita]

👍