Skip to content

Allow ellipsis "pages" to be used as buttons #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow ellipsis "pages" to be used as buttons #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions dirPagination.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,10 +326,27 @@
}
});

scope.setCurrent = function(num) {
if (paginationService.isRegistered(paginationId) && isValidPageNumber(num)) {
num = parseInt(num, 10);
paginationService.setCurrentPage(paginationId, num);
scope.setCurrent = function (num, index) {
if (paginationService.isRegistered(paginationId)) {
if (num === '...') {
/* Ellipsis entry */
// setCurrent is being called on an ellipsis, so assume that it's being used as a button and we need to work out where it should go.
if (index === 1) { // Opening Ellipsis
// Get the first page after the opening ellipsis to find which page comes before it. For example, given the page set 1 ... 15, 16, 17, selecting the opening ellipsis,
// would result in page 14 (scope.pages[index + 1] = 15 - 1 = 14) becoming selected.
num = scope.pages[index + 1] - 1; // Verbose for clarity.
}
else { // Closing Ellipsis
// Get the last page before the closing ellipsis to find which page should come next.
num = scope.pages[index - 1] + 1;
}
}

if (isValidPageNumber(num)) {
num = parseInt(num, 10);

paginationService.setCurrentPage(paginationId, num);
}
}
};

Expand Down
2 changes: 1 addition & 1 deletion dirPagination.tpl.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<a href="" ng-click="setCurrent(pagination.current - 1)">&lsaquo;</a>
</li>
<li ng-repeat="pageNumber in pages track by tracker(pageNumber, $index)" ng-class="{ active : pagination.current == pageNumber, disabled : pageNumber == '...' }">
<a href="" ng-click="setCurrent(pageNumber)">{{ pageNumber }}</a>
<a href="" ng-click="setCurrent(pageNumber, $index)">{{ pageNumber }}</a>
</li>

<li ng-if="directionLinks" ng-class="{ disabled : pagination.current == pagination.last }">
Expand Down