SysUtils bug

[jpmandon]

Hi Michael
I recently installed a new version of the compiler with fpcupdeluxe. Sysutils seem to be broken, I have a hardfault when executing sysutils.init.
My last operational version was:
FPC update at: 30-11-22 23:26:32
FPC URL: https://gitlab.com/michael-ring/freepascal-sources/
FPC previous rev/hash: FRET_UNKNOWN_REVISION
FPC new GIT hash: 3.3.1-9929-g8d63a1ddfd

Lazarus update at: 30-11-22 23:34:22
Lazarus URL: https://gitlab.com/freepascal.org/lazarus/lazarus.git/
Lazarus previous rev/hash: FRET_UNKNOWN_REVISION
Lazarus new GIT hash: main-2_3-2952-g6d1574db34

The new version with the Sysutils bug:
FPC update at: 28-9-24 18:29:16
FPC URL: https://gitlab.com/michael-ring/freepascal-sources/
FPC previous rev/hash: FRET_UNKNOWN_REVISION
FPC new GIT hash: 3.3.1-15743-g3e16d976de

Lazarus update at: 28-9-24 18:38:29
Lazarus URL: https://gitlab.com/freepascal.org/lazarus/lazarus.git/
Lazarus previous rev/hash: FRET_UNKNOWN_REVISION
Lazarus new GIT hash: main_3_99-3234-g0d63ab6747

Everything work OK when I use System call for conversion function ( inttostr and hexStr ).

[jpmandon]

Hi Michael, the bug is in sysutils.inc.

class constructor TOSVersion.Create;

{$IFNDEF HAS_OSVERSION}
var
S : String;
{$ENDIF}
begin
FArchitecture:=GetCompiledArchitecture;
FPlatform:=GetCompiledPlatform;
FBuild:=0;
FMajor:=0;
FMinor:=0;
FServicePackMajor:=0;
FServicePackMinor:=0;
{$IFDEF HAS_OSVERSION}
InitOSVersion;
{$ELSE}
WriteStr(S,GetCompiledPlatform);
FName:=Copy(S,3);
WriteStr(S,GetCompiledArchitecture);
FFull:=Copy(S,3)+'-'+FName;
{$ENDIF}
end;

the result of the writestr instructions is a _hardfault.

Fixed with this code:
{$IFDEF HAS_OSVERSION}
InitOSVersion;
{$ELSE}
if FPlatform<>pfEmbedded then
begin
WriteStr(S,GetCompiledPlatform);
WriteStr(S,GetCompiledArchitecture);
end;
FName:=Copy(S,3);
FFull:=Copy(S,3)+'-'+FName;
{$ENDIF}

And now everything is OK.

[jpmandon]

I published a patch to solve this problem.
https://github.com/jpmandon/patch-fpcupdeluxe-Raspberry-pico
( Lazarus 4.99 (rev main_4_99-2759-g7aa7dcd965) FPC 3.3.1 x86_64-linux-gtk2 main_4_99-2759 )