Replaced hard coded ports with dynamically assigned values from set_env file#17
Merged
okhleif-10 merged 5 commits intommqna-image-queryfrom Dec 30, 2024
Merged
Replaced hard coded ports with dynamically assigned values from set_env file#17okhleif-10 merged 5 commits intommqna-image-queryfrom
okhleif-10 merged 5 commits intommqna-image-queryfrom
Conversation
Signed-off-by: okhleif-IL <omar.khleif@intel.com>
Signed-off-by: okhleif-IL <omar.khleif@intel.com>
Signed-off-by: okhleif-IL <omar.khleif@intel.com>
dmsuehir
requested changes
Dec 21, 2024
Collaborator
|
The Gaudi LVM uses tgi-llava (https://github.com/mhbuehler/GenAIComps/blob/main/comps/lvms/tgi-llava/lvm_tgi.py) |
Signed-off-by: okhleif-IL <omar.khleif@intel.com>
Signed-off-by: okhleif-IL <omar.khleif@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed all instances of hard coded ports in MMQnA and replaced them with values set from the set_env file in GenAIExamples.
Linked with This GenAIExamples PR
Issues
N/A
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
N/A
Tests
Tested by setting env vars, building, composing, and verifying logs.