MultimodalQnA PDF Ingestion#16
Merged
mhbuehler merged 5 commits intommqna-image-queryfrom Jan 8, 2025
Merged
Conversation
Signed-off-by: Melanie Buehler <melanie.h.buehler@intel.com>
Signed-off-by: Melanie Buehler <melanie.h.buehler@intel.com>
2 tasks
mhbuehler
changed the title
Signed-off-by: Melanie Buehler <melanie.h.buehler@intel.com>
Signed-off-by: Melanie Buehler <melanie.h.buehler@intel.com>
dmsuehir
requested changes
Dec 16, 2024
Collaborator
dmsuehir
left a comment
dmsuehir
left a comment
There was a problem hiding this comment.
Could you also update the README here? It looks like it already mentioned png, but we should mention the limitations and what format works best (for example, text on the same page as the image are associated together, can there multiple images on the same page, etc)
comps/dataprep/multimodal/redis/langchain/prepare_videodoc_redis.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Melanie Buehler <melanie.h.buehler@intel.com>
dmsuehir
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds PDF ingestion capability to the MultimodalQnA dataprep service. It extracts images and text appearing on the same page together, embeds them with BridgeTower, and stores the results in redis. This uses a new external dependency
pymupdfand goes with this frontend PR in GenAIExamples.Issues
RFC
Type of change
Dependencies
New dependency for MMQnA:
pymupdfTests
There is a new test in
tests/dataprep/test_dataprep_multimodal_redis_langchain.shand new tests in the PR for GenAIExamples MultimodalQnA.