Skip to content

Fix port number placement#15

Merged
mhbuehler merged 1 commit intommqna-audio-queryfrom
melanie/port_placement
Dec 6, 2024
Merged

Fix port number placement#15
mhbuehler merged 1 commit intommqna-audio-queryfrom
melanie/port_placement

Conversation

@mhbuehler
Copy link
Copy Markdown
Owner

Description

The test port number needs to be set as an env var before the MultimodalQnAGateway is imported.

Issues

RFC

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Dependencies

N/A

Tests

The new audio query unit test passes locally now, so it should in GHA too.

Signed-off-by: Melanie Buehler <melanie.h.buehler@intel.com>
Copy link
Copy Markdown
Collaborator

@ashahba ashahba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed

Copy link
Copy Markdown
Collaborator

@dmsuehir dmsuehir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhbuehler mhbuehler merged commit 75b135f into mmqna-audio-query Dec 6, 2024
@mhbuehler mhbuehler deleted the melanie/port_placement branch December 6, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants