Fixed role bug where enumeration was wrong#13
Merged
mhbuehler merged 2 commits intommqna-audio-queryfrom Dec 4, 2024
Merged
Conversation
Signed-off-by: okhleif-IL <omar.khleif@intel.com>
mhbuehler
reviewed
Dec 4, 2024
Owner
mhbuehler
left a comment
mhbuehler
left a comment
There was a problem hiding this comment.
It looks like there is some extra whitespace in line 906. The linter may not like that.
Signed-off-by: okhleif-IL <omar.khleif@intel.com>
mhbuehler
approved these changes
Dec 4, 2024
dmsuehir
approved these changes
Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
in the loop on line 906, the variable
iwas in the wrong block and therefore it would never equal to a value greater than 0. This caused role to never be concatenated to the prompt string later on.Issues
https://github.com/opea-project/docs/blob/main/community/rfcs/24-10-02-GenAIExamples-001-Image_and_Audio_Support_in_MultimodalQnA.md
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
N/A
Tests
Verified fix with print statements