Skip to content

Conversation

@Ashmash100
Copy link

Description

Resolved issue : 475

Demo

Papermark._.The.Open.Source.DocSend.Alternative.-.Google.Chrome.2024-07-25.09-35-44.mp4

@Ashmash100 Ashmash100 requested a review from mfts as a code owner July 25, 2024 04:09
@vercel
Copy link

vercel bot commented Jul 25, 2024

@JosephAshwin23 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

@mfts
Copy link
Owner

mfts commented Jul 26, 2024

Hi @Ashmash100 that's a great starting point.

A couple of points:

  • folders and documents should be sortable together (i.e. doc1 can be on position 1, folder1 on position 2)
  • we need a new database field on the DataroomDocument and DataroomFolder to manage the position
  • add an api function that persists the position of the dragged item in the database

@mfts
Copy link
Owner

mfts commented Aug 9, 2024

@Ashmash100 I implemented the dataroom sorting in #558

Would love your help on other issues :)

@mfts mfts closed this Aug 9, 2024
@Ashmash100
Copy link
Author

@Ashmash100 I implemented the dataroom sorting in #558

Would love your help on other issues :)

@mfts That’s amazing! I apologize for not being able to complete the PR as I got a bit occupied. However, I wanted to say that I absolutely loved working with the codebase.

I was wondering if you might have any openings for a full-time frontend role. I would be thrilled to join the team and contribute more permanently.

@mfts
Copy link
Owner

mfts commented Aug 9, 2024

@Ashmash100 no need to apologize.

I was wondering if you might have any openings for a full-time frontend role.

Not at this moment, but I'm happy to keep you up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants