-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add spacing between logo and home button #1873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spacing between logo and home button #1873
Conversation
Co-authored-by: marcftone <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughAdds a Tailwind class (ml-6) to the Breadcrumb component in the isDataroom branch of components/view/nav.tsx. No logic, structure, or exported/public entity signatures changed. Other branches remain unaffected. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/view/nav.tsx (1)
227-229: Optional: prefer parent gap or responsive margin for consistency.Two low-risk options:
- Option A (preferred for consistency across branches): add gap on the left container and drop the child margin.
-<div className="flex flex-1 items-center justify-start"> +<div className="flex flex-1 items-center justify-start gap-6"> ... -<Breadcrumb className="ml-6"> +<Breadcrumb>
- Option B (if keeping child margin): make spacing responsive to tighter mobile widths.
-<Breadcrumb className="ml-6"> +<Breadcrumb className="ml-4 sm:ml-6">Please sanity-check on narrow viewports (~320–375px) to ensure no crowding or wrap regressions.
Also applies to: 249-271
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/view/nav.tsx(1 hunks)
🔇 Additional comments (1)
components/view/nav.tsx (1)
249-249: LGTM: added left spacing achieves the stated UI objective.
ml-6on the Breadcrumb container cleanly separates the logo from “Home” in the dataroom navbar without affecting behavior.
Add horizontal padding between the logo and the "Home" button in the dataroom navbar.
This improves the visual separation and overall layout of the dataroom navbar.
Slack Thread
Summary by CodeRabbit