Skip to content

Conversation

@mfts
Copy link
Owner

@mfts mfts commented Sep 11, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Improved reliability of bulk data room downloads by allowing longer processing time, reducing timeout errors for large archives and busy periods.
    • Enhances completion rates for multi-file exports, especially on slower networks or when downloading extensive content.
    • Users should experience fewer failed or partial downloads during bulk operations, with more consistent results and less need to retry.

@vercel
Copy link

vercel bot commented Sep 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
papermark Ready Ready Preview Comment Sep 11, 2025 9:26pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 11, 2025

Walkthrough

In a single API route file, the exported config’s maxDuration value was increased from 180 to 300. No other code paths or logic were modified.

Changes

Cohort / File(s) Summary
API route config update
pages/api/teams/[teamId]/datarooms/[id]/download/bulk.ts
Updated exported config.maxDuration from 180 to 300; no other logic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • feat: extend #1812 — Similar change updating config.maxDuration from 180 to 300 in another API route.

Pre-merge checks (1 passed, 2 warnings)

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The pull request title "feat: extend max duration" is partially related to the changeset but lacks specificity about what exactly is being extended. While the title correctly identifies that a duration is being extended (which aligns with increasing maxDuration from 180 to 300 seconds), it fails to provide context about which component or functionality is affected. The title is too generic and could apply to many different parts of a codebase, making it difficult for teammates to understand that this specifically relates to a bulk download API route's execution timeout. The title should be more specific about what duration is being extended and in what context. A better title would be something like "feat: increase bulk download API timeout to 300 seconds" or "feat: extend maxDuration for bulk dataroom download endpoint" to clearly communicate which functionality is being modified and provide meaningful context for developers reviewing the code history.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bedfd39 and 1373d82.

📒 Files selected for processing (1)
  • pages/api/teams/[teamId]/datarooms/[id]/download/bulk.ts (1 hunks)
🔇 Additional comments (2)
pages/api/teams/[teamId]/datarooms/[id]/download/bulk.ts (2)

12-14: LGTM: Increased maxDuration to 300.

Change is straightforward and aligns with the PR intent.


12-14: Vercel supports export const config = { maxDuration } — confirm runtime/plan & upstream timeouts

  • Verified: Pages API routes accept export const config = { maxDuration: N } and Vercel will honor it, but limits vary by runtime/plan (Edge requires starting a response within ~25s; Serverless limits differ by plan and by whether “fluid compute”/legacy behavior is used).
  • Action: confirm this route will run on a Serverless runtime/plan that permits 300s (or raise the function timeout in Vercel); also verify client/proxy/load‑balancer/AWS‑SDK timeouts won’t cut the request earlier. If work may exceed available windows, move to a background job/queue + polling or stream/partial responses.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/bulk

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mfts mfts merged commit 0fec2b8 into main Sep 11, 2025
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2025
@mfts mfts deleted the feat/bulk branch September 16, 2025 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants