fix: watermark on partial folder downloads

[mfts]

Summary by CodeRabbit

• New Features

  • Enhanced watermarking for document downloads, including personalized watermark details such as viewer email, view date/time, link name, and viewer IP address when watermarking is enabled.

• Bug Fixes

  • Improved logic for selecting the correct file version based on watermarking settings and document type.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
papermark	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 24, 2025 9:12pm

[coderabbitai]

Walkthrough

The API handler for dataroom folder downloads now extracts the viewer's IP address using a utility function, expands the Prisma query to include additional link and viewer fields, updates file selection logic for watermarking, and sends an enriched watermark configuration in the Lambda payload when watermarking is enabled.

Changes

File(s)	Change Summary
pages/api/links/download/dataroom-folder.ts	Uses utility to extract IP address, expands Prisma query to include more fields, updates file selection for watermarking, and enriches Lambda payload with watermark config and viewer metadata.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant API_Handler
    participant Prisma_DB
    participant Lambda

    Client->>API_Handler: Request dataroom folder download
    API_Handler->>Prisma_DB: Fetch link, viewer, and watermark config
    Prisma_DB-->>API_Handler: Return link and viewer data
    API_Handler->>API_Handler: Extract IP address, determine files and watermark config
    API_Handler->>Lambda: Send payload (files, watermarkConfig, viewer info)
    Lambda-->>API_Handler: Processed download (with/without watermark)
    API_Handler-->>Client: Return download response

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• Feat: Download specific folder / subfolder in dataroom (viewmode) #1626: Adds folder download UI and permission logic, and introduces the initial version of the same API route handler for folder downloads, directly related to the endpoint refined in this PR.
• fix: watermark documents on bulk download #1691: Enhances bulk download API handler with watermarking support, similar to this PR's enhancements for dataroom folder downloads.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-07-24T21_10_58_796Z-debug-0.log

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c0fc249 and 2283647.

📒 Files selected for processing (1)

• pages/api/links/download/dataroom-folder.ts (5 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

pages/api/links/download/dataroom-folder.ts (1)

lib/utils/ip.ts (1)

• getIpAddress (1-8)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (4)

pages/api/links/download/dataroom-folder.ts (4)

10-10: LGTM! Clean import for IP extraction utility.

The import is necessary for watermarking functionality and the utility function handles IP extraction safely with proper fallbacks.

---

47-47: LGTM! Properly expanded query for watermarking support.

The additional fields (viewerEmail, enableWatermark, watermarkConfig, name, numPages, contentType) are all necessary for the watermarking functionality and are correctly added to the Prisma select statements.

Also applies to: 54-56, 133-134

---

251-255: LGTM! Appropriate file key selection for watermarking.

The logic correctly selects the watermarked file for PDFs when watermarking is enabled, with a proper fallback to original files for other scenarios. The conditional logic and fallback chain are well-structured.

---

282-294: LGTM! Comprehensive watermark configuration for Lambda processing.

The watermark configuration properly includes all necessary viewer data (email, timestamp, link name, IP address) when enabled, with appropriate fallback when disabled. The structure will provide sufficient context for watermarking in the Lambda function.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/watermark

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.