-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: banner cover on larger screens #1698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe change updates the CSS classes for the banner image in the dataroom navigation component, introducing the Changes
Possibly related PRs
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm error Exit handler never called! ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/view/dataroom/nav-dataroom.tsx (1)
206-214: Optional: switch to Next.js<Image>for better performanceThe
<img>tag disables the built-in optimisation pipeline (responsive src-sets, lazy-loading, caching) that Next.js provides.
If you can, migrate tonext/image:-import React, { useEffect, useState } from "react"; +import Image from "next/image"; ... -<img - className="h-full w-full object-cover sm:max-h-80 sm:object-contain xl:object-cover" - src={brand?.banner || DEFAULT_BANNER_IMAGE} - alt="Banner" - width={1920} - height={320} /> +<Image + className="h-full w-full object-cover sm:max-h-80 sm:object-contain xl:object-cover" + src={brand?.banner || DEFAULT_BANNER_IMAGE} + alt="Banner" + width={1920} + height={320} + priority + sizes="(max-width: 640px) 100vw, 100vw" />You’ll gain automatic optimisation and maintain semantic parity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/view/dataroom/nav-dataroom.tsx(1 hunks)
🔇 Additional comments (1)
components/view/dataroom/nav-dataroom.tsx (1)
209-209: Breakpoint-awareobject-fitaddition LGTM
xl:object-covercleanly reverts the fit behaviour at thexlbreakpoint while preservingobject-containbetweensm-lg. The cascade order in Tailwind ensures the correct rule wins, so no further action needed.
Summary by CodeRabbit