fix: load people properly

[mfts]

Summary by CodeRabbit

• Refactor
  • Improved how document ownership and counts are managed and displayed for team members, providing more accurate and efficient information.
• Chores
  • Updated and cleaned up internal imports to remove unused dependencies.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
papermark	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 30, 2025 3:15pm

[coderabbitai]

Walkthrough

The changes restructure the TeamDetail interface to adjust the placement of the userId field, remove the per-user document count, and introduce a new documents array with owner information. The API and UI logic are updated to align with this new structure, shifting document count computation from backend to frontend.

Changes

File(s)	Change Summary
lib/types.ts	Modified TeamDetail interface: reordered userId, removed _count from users, added documents array with owner info.
pages/api/teams/[teamId]/index.ts	Updated Prisma query: removed per-user document count, added retrieval of team documents with owner details.
pages/settings/people.tsx	Refactored document count logic: computes counts in frontend using a memoized map over team documents; updated imports.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant API (teams/[teamId]/index)
    participant DB

    Client->>API (teams/[teamId]/index): Request team details
    API (teams/[teamId]/index)->>DB: Query team, users, and documents with owner info
    DB-->>API (teams/[teamId]/index): Return team, users, documents (with owner)
    API (teams/[teamId]/index)-->>Client: Respond with structured team data
    Client->>Client: Memoize document counts by user from documents array

Loading

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-05-30T15_12_46_650Z-debug-0.log

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 101cc58 and 9fefaa1.

📒 Files selected for processing (3)

• lib/types.ts (1 hunks)
• pages/api/teams/[teamId]/index.ts (1 hunks)
• pages/settings/people.tsx (2 hunks)

🔇 Additional comments (6)

lib/types.ts (2)

317-317: Good improvement to field ordering.

Moving the userId field to precede the user object improves readability and logical grouping of the user-related fields.

---

322-328:

Details

❓ Verification inconclusive

Verify performance impact of the data structure change.

The restructuring from embedded _count properties to a separate documents array is a good architectural improvement that provides more flexibility. However, this change shifts from fetching aggregated counts to fetching all documents, which could have performance implications for teams with large numbers of documents.

Please run the following script to check the typical document count per team to assess performance impact:

---

🏁 Script executed:

#!/bin/bash
# Description: Analyze document counts per team to assess performance impact
# Expected: Information about document distribution across teams

# Search for any existing queries that might give insight into document counts
ast-grep --pattern 'documents: {
  $$$
}'

# Look for any existing performance considerations or limits
rg -i "limit|pagination|performance" --type ts -A 3 -B 3

Length of output: 86037

---

Review performance implications of returning full documents array by default

This change replaces the aggregated _count field with a full documents: { owner: { name, id } }[] property. While more flexible, it now fetches all document objects rather than just a count whenever the API is called.

Please verify the following to assess potential performance impact:

• In lib/swr/use-documents.ts, pagination (?page/limit) is only applied when search or sort parameters are present. By default, the endpoint returns the entire documents array.
• In pages/documents/index.tsx, the UI loads and renders all documents if no filters are applied (no pagination controls shown).
• Confirm typical document volumes per team by running a query against your production database, for example:

  SELECT teamId, COUNT(*) AS docCount
    FROM Document
   GROUP BY teamId
   ORDER BY docCount DESC
   LIMIT 10;

• If teams commonly have large document sets (hundreds or more), consider:
  • Enforcing a default limit on the /api/teams/[teamId]/documents endpoint.
  • Always applying pagination on the client, even when no filters are active.

pages/api/teams/[teamId]/index.ts (1)

49-52: Correctly removes the embedded count selection.

The removal of the nested _count selection aligns perfectly with the updated TeamDetail interface that no longer includes document counts within user objects.

pages/settings/people.tsx (3)

3-3: Correctly adds useMemo import for memoization.

The addition of useMemo import is appropriate for the new memoized document count computation pattern.

---

52-63: Excellent implementation of document count computation.

The memoized documentCountsByUser computation correctly implements the new approach:

• Properly handles the case when team?.documents is undefined
• Correctly iterates through documents and counts by owner.id
• Uses appropriate memoization with team as the dependency
• Handles edge cases where owner?.id might be missing

The logic is clean, efficient, and type-safe.

---

66-66: Clean and efficient implementation of getUserDocumentCount.

The updated function correctly uses the memoized documentCountsByUser map and provides a sensible default of 0 for users with no documents.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.